feat: Add prefix and secondaryText to Token - #5090
Draft
NathanZlion wants to merge 6 commits into
Draft
NathanZlion wants to merge 6 commits into
NathanZlion wants to merge 6 commits into
Conversation
Add a prefix slot before the label (for example a category color dot) and a secondaryText value after it. Includes a Token additions dev page demoing both, plus popover composition in the label slot.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5090 +/- ##
==========================================
+ Coverage 97.66% 97.70% +0.03%
==========================================
Files 959 989 +30
Lines 31340 31791 +451
Branches 11578 11738 +160
==========================================
+ Hits 30609 31062 +453
- Misses 685 722 +37
+ Partials 46 7 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds two props to Token, per the Token additions API proposal:
prefix: anaria-hiddenslot before the label, for example a category color dot.secondaryText: a lighter value shown after the label, for example a coverage percentage.Existing tokens are unchanged. The new dev page
token/additionsdemos both props, the inline variant, and composing a Popover in the label slot together with prefix and secondary text. The API proposal links to this PR as the demo.This is a draft for demo purposes. Test-utils finders and unit tests for the new props will follow.
How has this been tested?
gulp quick-buildpasses locallyReview checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.