Skip to content

feat: Add prefix and secondaryText to Token - #5090

Draft
NathanZlion wants to merge 6 commits into
mainfrom
dev-v3-natidere-token-additions
Draft

NathanZlion wants to merge 6 commits into
mainfrom
dev-v3-natidere-token-additions

Conversation

@NathanZlion

Copy link
Copy Markdown
Member

Description

Adds two props to Token, per the Token additions API proposal:

  • prefix: an aria-hidden slot before the label, for example a category color dot.
  • secondaryText: a lighter value shown after the label, for example a coverage percentage.

Existing tokens are unchanged. The new dev page token/additions demos both props, the inline variant, and composing a Popover in the label slot together with prefix and secondary text. The API proposal links to this PR as the demo.

This is a draft for demo purposes. Test-utils finders and unit tests for the new props will follow.

How has this been tested?

  • gulp quick-build passes locally
  • Existing token unit tests pass (79/79)
  • Checked visually on the dev page

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add a prefix slot before the label (for example a category color dot) and a secondaryText value after it. Includes a Token additions dev page demoing both, plus popover composition in the label slot.
@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.70%. Comparing base (fc0c496) to head (c30ae11).
⚠️ Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5090      +/-   ##
==========================================
+ Coverage   97.66%   97.70%   +0.03%     
==========================================
  Files         959      989      +30     
  Lines       31340    31791     +451     
  Branches    11578    11738     +160     
==========================================
+ Hits        30609    31062     +453     
- Misses        685      722      +37     
+ Partials       46        7      -39     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

3 active deployments
dev-pages-react18 — c30ae111 Deployed Oct 1, 2026 by NathanZlion via deploy (React 18) / deploy #2503
dev-pages-react16 — c30ae111 Deployed Oct 1, 2026 by NathanZlion via deploy (React 16) / deploy #2503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant