chore: Add i18n strings for contentDisplayPreference.liveAnnouncementDndGroupLabel - #4847
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4847 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 957 957
Lines 31097 31097
Branches 11434 11435 +1
=======================================
Hits 30361 30361
+ Misses 729 689 -40
- Partials 7 47 +40 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
NathanZlion
force-pushed
the
dev-v3-natidere-collection_prefs_i18n
branch
from
July 29, 2026 17:03
aff9a39 to
ea1caf3
Compare
There was a problem hiding this comment.
Pull request overview
Adds the missing i18n message key for contentDisplayPreference.liveAnnouncementDndGroupLabel so drag-and-drop live announcements for grouped items can be localized consistently across supported locales.
Changes:
- Add
contentDisplayPreference.liveAnnouncementDndGroupLabeltranslations to multiple locale bundles. - Update the English message to include an explicit
zeroplural branch. - Adjust
I18nFormatArgTypesforcontentDisplayPreference.liveAnnouncementDndGroupLabel.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/i18n/messages/all.zh-TW.json | Adds the new liveAnnouncementDndGroupLabel message for zh-TW. |
| src/i18n/messages/all.zh-CN.json | Adds the new liveAnnouncementDndGroupLabel message for zh-CN. |
| src/i18n/messages/all.tr.json | Adds the new liveAnnouncementDndGroupLabel message for Turkish. |
| src/i18n/messages/all.pt-BR.json | Adds the new liveAnnouncementDndGroupLabel message for pt-BR. |
| src/i18n/messages/all.ko.json | Adds the new liveAnnouncementDndGroupLabel message for Korean. |
| src/i18n/messages/all.ja.json | Adds the new liveAnnouncementDndGroupLabel message for Japanese. |
| src/i18n/messages/all.it.json | Adds the new liveAnnouncementDndGroupLabel message for Italian. |
| src/i18n/messages/all.id.json | Adds the new liveAnnouncementDndGroupLabel message for Indonesian. |
| src/i18n/messages/all.fr.json | Adds the new liveAnnouncementDndGroupLabel message for French. |
| src/i18n/messages/all.es.json | Adds the new liveAnnouncementDndGroupLabel message for Spanish. |
| src/i18n/messages/all.en.json | Updates English liveAnnouncementDndGroupLabel to include a zero case and consistently include {label} in each branch. |
| src/i18n/messages/all.en-GB.json | Adds the new liveAnnouncementDndGroupLabel message for en-GB. |
| src/i18n/messages/all.de.json | Adds the new liveAnnouncementDndGroupLabel message for German. |
| src/i18n/messages/all.ar.json | Adds the new liveAnnouncementDndGroupLabel message for Arabic. |
| src/i18n/messages-types.ts | Updates format-arg typing for the new/updated message key. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
146
to
149
| 'contentDisplayPreference.liveAnnouncementDndGroupLabel': { | ||
| label: string; | ||
| count: number; | ||
| label: string | number; | ||
| }; |
| "contentDisplayPreference.i18nStrings.columnFilteringClearFilterText": "Clear filter", | ||
| "contentDisplayPreference.liveAnnouncementDndItemReordered": "{isInitialPosition, select, true {Moving item back to position {currentPosition} of {total}} false {Moving item to position {currentPosition} of {total}} other {}}", | ||
| "contentDisplayPreference.liveAnnouncementDndItemCommitted": "{isInitialPosition, select, true {Item moved back to its original position {initialPosition} of {total}} false {Item moved from position {initialPosition} to position {finalPosition} of {total}} other {}}", | ||
| "contentDisplayPreference.liveAnnouncementDndGroupLabel": "{count, plural, zero {{label}, 0 items} one {{label}, 1 item} other {{label}, {count} items}}", |
NathanZlion
marked this pull request as ready for review
July 29, 2026 17:38
NathanZlion
requested review from
SpyZzey and
mxschll
and removed request for
a team and
SpyZzey
July 29, 2026 17:38
NathanZlion
force-pushed
the
dev-v3-natidere-collection_prefs_i18n
branch
from
July 29, 2026 17:49
ea1caf3 to
7b8ebeb
Compare
mxschll
approved these changes
Jul 29, 2026
NathanZlion
enabled auto-merge
July 29, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the missing i18n message key for contentDisplayPreference.liveAnnouncementDndGroupLabel so drag-and-drop live announcements for grouped items can be localized consistently across supported locales.
Changes:
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.