Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic classes are reconstructed before their slots attribute is restored. Assigning slots after type creation cannot change the instance layout, so slotted objects silently gain a writable dict after transfer to another process. A same-process round trip can hide this because the dynamic-class tracker reuses the original class.
Pass declared slots into class construction. Keep NamedTuple's generated slots under its metaclass's control, including the optional typing_extensions variant. Add a subprocess regression with slotted inheritance that checks field values and rejection of undeclared attributes, plus a NamedTuple compatibility test.
Validation on Windows/Python 3.12: the subprocess regression fails on the original code for both tested pickle protocols. The full suite passes after the fix: 270 passed, 10 skipped, 2 expected failures. Black 25.9.0 formatting and Ruff lint pass for both changed files.