Increase NLTK test timeout to fix flaky test - #1218
Open
tnikolova82 wants to merge 1 commit into
Open
Conversation
The NLTK corpus test can take longer than the default 10s timeout on first request when loading corpus data. Increase to 30s to prevent intermittent failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The NLTK integration test (
when pushing an app that uses nltk corpus / deploys successfully) occasionally times out because corpus data loading on the first HTTP request can exceed the default 10-second Eventually timeout.Solution
Use Gomega's per-assertion timeout override:
Eventually(deployment, 30*time.Second).Should(...)This is a targeted fix that only affects the NLTK test without changing the global timeout for other tests.