Issue 1229 fix: Application Insights connection string shell splitting on semicolon

[stokpop]

Problem

When APPLICATIONINSIGHTS_CONNECTION_STRING contains a semicolon (e.g., InstrumentationKey=...;IngestionEndpoint=https://...), the application fails to start.

The start command uses:

eval exec $JAVA_HOME/bin/java $JAVA_OPTS -jar app.jar

Because $JAVA_OPTS is unquoted, bash's eval treats the semicolon as a command separator. Java runs without -jar app.jar, prints usage output, and exits 1. The agent starts correctly but the application never launches.

Fixes #1229.

Root cause

The -Dapplicationinsights.connection.string=KEY;Endpoint=... token is split by eval at the ;.

Fix

Single-quote the connection string value in the opts file:

-Dapplicationinsights.connection.string='KEY;Endpoint=...'

Single quoting is safe here because Azure connection strings never contain single quotes. The JVM receives the full value correctly after eval expands the shell command.

Tests

Added/updated 4 tests in azure_application_insights_agent_test.go covering:

• Env var with semicolon in connection string
• Service binding (snake_case) with semicolon
• Service binding (camelCase) with semicolon
• Precedence: connection string over instrumentation key (also with semicolon)