Introduce set_env method in db options factory - #5413
Draft
philippthun wants to merge 1 commit into
Draft
Conversation
VCAP::CloudController::DB invokes dedicated factories for MySQL and Postgres connection options. Add 'set_env' methods to the factories that set required environment variables depending on the adapter type and call it just before building the connection options. This mechanism provides a single place where e.g. MARIADB_TLS_DISABLE_PEER_VERIFICATION can be set instead of exporting it in various code places.
philippthun
force-pushed
the
mysql-tls-disable-peer-verification
branch
from
September 2, 2026 11:25
c937123 to
029ba10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VCAP::CloudController::DBinvokes dedicated factories for MySQL and Postgres connection options. Addset_envmethods to the factories that set required environment variables depending on the adapter type and call it just before building the connection options. This mechanism provides a single place where e.g.MARIADB_TLS_DISABLE_PEER_VERIFICATIONcan be set instead of exporting it in various code places.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests