Do not propagate exception inside HTMLRewriter parser#5976
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5976 +/- ##
==========================================
- Coverage 70.17% 70.17% -0.01%
==========================================
Files 407 407
Lines 107238 107241 +3
Branches 17985 17985
==========================================
Hits 75257 75257
- Misses 21195 21196 +1
- Partials 10786 10788 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b5b3a4a to
bd2e85b
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
dom96
left a comment
There was a problem hiding this comment.
Could this have any impact on existing code in prod? i.e. do we need to do this behind a new compat flag?
|
@dom96 it should not have a negative impact. This is undoing part of another recent change that landed within the past two weeks. |
bd2e85b to
ccb8ecd
Compare
ccb8ecd to
8faa650
Compare
When an exception is threw inside HTMLRewriter handler, that error marks the task as failure and make subsequent transforms fail. This PR changes it to catch the exception so it is not propagated other than the stream.