Fix: Adding support for namespace when collecting logs from Kubernetes deployments#1464
Open
nirav-chotai wants to merge 1 commit intocloudflare:masterfrom
Open
Fix: Adding support for namespace when collecting logs from Kubernetes deployments#1464nirav-chotai wants to merge 1 commit intocloudflare:masterfrom
nirav-chotai wants to merge 1 commit intocloudflare:masterfrom
Conversation
…loyment If tunnel is deployed in K8s other than default namespace, then this will allow to specify namespace option to collect logs from.
Contributor
|
Hi @nirav-chotai can you please rebase the PR and add some unit-tests, ensure that everything is compiling and passing all tests. Thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: If tunnel is deployed in other namespace than
defaultthencloudflared tunnel diagwill fail to collect logs as there is no option to pass thenamespaceas an argument.Solution: If tunnel is deployed in K8s other than default namespace, then this will allow to specify namespace option to collect logs from when running
cloudflared tunnel diag