docs(aws-sdk-js-v3): corrected Content-Type presigning examples#27832
Open
BoogeyMan24 wants to merge 3 commits intocloudflare:productionfrom
Open
docs(aws-sdk-js-v3): corrected Content-Type presigning examples#27832BoogeyMan24 wants to merge 3 commits intocloudflare:productionfrom
BoogeyMan24 wants to merge 3 commits intocloudflare:productionfrom
Conversation
Content-Type is not signed by default. It must be added to signableHeaders for it to be signed. Added a warning and a link to official docs to ensure people protect their urls correctly.
…/s3/presigned-ruls Updated the presigned URL generation example to include signableHeaders for ContentType restriction.
Before: "Specify ContentTypea and add it to the signableHeaders..." Now: "Specify ContentType and add it to signableHeaders"
Author
|
bump |
Contributor
|
Hey there, we've marked this pull request as stale because there's no recent activity on it. This label is helps us identify PRs that might need updates (or to be closed out by our team if no longer relevant). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The documentation was stating that:
However, ContentType header is NOT signed by default and signableHeaders must be added for the header to be signed:
This PR adds the required signableHeaders to the examples in the documentation so that Content-Type is signed.
Source: https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/Package/-aws-sdk-s3-request-presigner/
Screenshots (optional)
none
Documentation checklist
not sure how to make a changelog. If its necessary, how do I do it?