[feature] Add support for user profiles API#724
[feature] Add support for user profiles API#724mlnm-capco wants to merge 4 commits intocloudbees-oss:masterfrom
Conversation
|
This would be a great thing to have, @duemir @PierreBtz would you have an opportunity to get this reviewed soon? 🙌 |
| public UserProfile getUserProfile(UserProfile userProfile) { | ||
| return getUserProfile(userProfile.getId()); | ||
| } |
There was a problem hiding this comment.
what's the purpose of this method?
|
Thanks for the contribution and sorry for the delay in reviewing this. I'll take some time next week to work on this. I'll also unblock the CI on this PR to have a run and make sure the test are passing. |
PierreBtz
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I found minor quirks that I think we should address prior to merging, but I'm ok overall with the change.
| private String source; | ||
| private String type; | ||
| private Date updatedAt; | ||
| private String userId; |
There was a problem hiding this comment.
looks odd to use aString here where the API (public List<UserProfile> getUserProfilesForUser(long userId) {) works with a long.
| } | ||
|
|
||
| public UserProfile createOrUpdateUserProfile( | ||
| UserProfile userProfile, String identifierType, String identifierValue) { |
There was a problem hiding this comment.
what about aligning with the UserProfile object and use an Identifier object here?
| handle(UserProfile.class, "profile"))); | ||
| } | ||
|
|
||
| public UserProfile getUserProfilebyIdentifier(String identifier) { |
There was a problem hiding this comment.
What about renaming the variable to queryIdentifier since this is not an identifier we are passing here, but an identifier query?
|
Hello there! I decided to give it a little push because those changes would be great to have! |
Adds support for the following User Profile CRUD operations (documented here)