docs(repo): Fixing billing broken links for Typedoc output - #9393
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-google-signin
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
🦋 Changeset detectedLatest commit: 61835eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR adds Billing documentation for credits, proration, discounts, and checkout fields. It restructures Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change updates generated documentation links and TypeDoc annotations without any identified actionable merge-blocking risk remaining. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
API Changes Report
Summary
@clerk/sharedCurrent version: 4.29.0 Subpath
|
- Add JSDoc for BillingAppliedDiscount.durationInCycles so excludeNotDocumented no longer drops it from the generated page - Clarify amountOff as the configured fixed amount vs the applied amount - Use absolute clerk.com doc URLs so the links resolve in IntelliSense - Add unit tests for the relative link replacements Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Pushed some changes directly in 763376e.
|
Description
Fixes broken and incomplete TypeDoc links and generated documentation for several billing types and checkout methods. The broken links were spotted in this TypeDoc-generated PR, which will ultimately be closed once this PR generates a new TypeDoc PR.
This PR:
BillingAppliedDiscountBillingCreditsBillingDiscountRedemptionBillingDiscountsBillingPaymentTotalsBillingPayerCreditBillingPeriodTotalsBillingProrationCreditDetailBillingProrationDiscountBillingSubscriptionItemNextPaymentBillingSubscriptionNextPaymentConfirmCheckoutParamsUpdateCheckoutParamsConfirmCheckoutParamsnow links to#confirm-parameters.UpdateCheckoutParamsnow links to#update-parameters.#confirmand#updatelinks with canonicalBillingCheckoutResourceURLs so they work when TypeDoc is embedded on other pages, such asuseCheckout().UpdateCheckoutParamsinto a directly documented object type while preserving its existingid,orgId, andpromoCodeproperties. This allows TypeDoc to generate a complete standalone property table.update-checkout-params.mdxso the fragment embeds cleanly beneath the Update parameters heading.BillingCreditsBillingPayerCreditBillingProrationCreditDetailBillingAppliedDiscountBillingDiscountRedemptionBillingCreditsproperties onBillingCheckoutTotalsandBillingSubscriptionItemResource, which were previously omitted from the generated output.ProtectAssertionandProtectAssertionResolveras inline types so TypeDoc does not generate broken standalone links.A fresh TypeDoc generation now produces standalone fragments with complete property tables for all five previously missing billing types:
billing-credits.mdxbilling-payer-credit.mdxbilling-proration-credit-detail.mdxbilling-applied-discount.mdxbilling-discount-redemption.mdxIn addition,
update-checkout-params.mdxnow renders a complete parameter table without a redundant Properties heading.clerk/clerk#3135 fixed the billing links whose TypeDoc fragments were already synced with Clerk Docs.
The five newly generated fragments above were intentionally not included in that Clerk PR. Once this JavaScript PR is released and the updated TypeDoc output is synced into Clerk Docs, I will merge clerk/clerk#3153 into the TypeDoc-generated PR to complete the remaining documentation changes.
To verify the changes, run:
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change