Draft
Conversation
The underlying issues that were causing these warnings have been resolved.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
==========================================
- Coverage 79.24% 78.03% -1.22%
==========================================
Files 29 29
Lines 4197 4197
Branches 538 538
==========================================
- Hits 3326 3275 -51
- Misses 727 767 +40
- Partials 144 155 +11 |
Member
Those Pythons are built differently than normally shipped versions. There will be differences in behavior, sometimes unnoticable. Also, you may want to drop the ignores in separate PRs to see if some of them would be fine in our CI, in isolation from other changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed via a sweep (using uv) across Python 3.10–3.13,
ignore:path is deprecated … :DeprecationWarning:certifi.core,ResourceWarning: unclosed <ssl.SSLSocket …>andPytestUnraisableExceptionWarning: Exception ignored in <function IOBase.__del__ …>are now all obsolete warning ignores as the deprecations no longer trigger in any of these Python versions.So far, on my test, these mentioned suppressions are safe to remove without any additional code changes, but let's see what the CI thinks.
❓ What kind of change does this PR introduce?
📋 What is the related issue number (starting with
#)Related to #768
❓ What is the current behavior? (You can also link to an open issue here)
Pytest is configured to suppress certain warnings (
DeprecationWarning,ResourceWarning,PytestUnraisableExceptionWarning) that no longer occur on supported Python versions.❓ What is the new behavior (if this is a feature change)?
Those warning ignores are removed; test output is cleaner, and we rely on CI to confirm no regressions.
📋 Contribution checklist:
(If you're a first-timer, check out
this guide on making great pull requests)
the changes have been approved
and description in grammatically correct, complete sentences
This change is