refactor: un-nest handle_edit_delete#8245
Open
WofWca wants to merge 1 commit into
Open
Conversation
Collaborator
|
link2xt
approved these changes
May 16, 2026
e1fbdd0 to
855153c
Compare
Collaborator
Author
|
Thanks! Makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Back before e10f95b
(#6664) this code was inlined
into
add_parts()so it couldn't utilize early returns.Now it can.
I only decided not to touch theedit_msg_showpadlockpart,because I don't understand the intended meaning of the condition
(this might be a bug).
Related:
remove_contact_from_chat#8108