fix(dom): update canvas style on resize to allow chart to grow#12188
Open
jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
Open
fix(dom): update canvas style on resize to allow chart to grow#12188jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
Conversation
When the chart's container grows, the canvas style width/height were not being updated because they were already set (from initial render). This caused the chart to shrink correctly but not grow when the window was enlarged. This fix updates the canvas style width/height during resize when they differ from the current chart dimensions, allowing the chart to properly resize in both directions. Fixes chartjs#12177
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12177
When a chart's container grows (e.g., window resize making the container larger), the canvas would not grow to fill the new space. The canvas style dimensions were only set initially but not updated on subsequent resizes.
Changes
retinaScalefunction inhelpers.dom.tsto update the canvas style dimensions during resize if they were previously set by Chart.jsTechnical Details
The fix checks if the current style dimensions differ from the chart dimensions and updates them accordingly. This maintains the behavior where Chart.js-managed styles are kept in sync with the actual chart size.