fix(scale): handle Number.MAX_VALUE in linear scale without overflow#12185
Open
jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
Open
fix(scale): handle Number.MAX_VALUE in linear scale without overflow#12185jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
jonathan-fulton wants to merge 1 commit intochartjs:masterfrom
Conversation
When a dataset contains extremely large values near Number.MAX_VALUE, the scale's tick generation algorithm could overflow when trying to compute 'nice' values, causing the chart to crash or the browser tab to become unresponsive. This fix: - Adds SAFE_MAX/SAFE_MIN constants (half of MAX_VALUE) to prevent overflow - Clamps data range values before tick generation calculations - Ensures niceMin/niceMax stay within safe bounds after rounding Fixes chartjs#12184
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12184
When a dataset contains
Number.MAX_VALUE, the linear scale's tick generation algorithm would overflow when computing "nice" tick values, causing the chart to crash or render incorrectly.Changes
SAFE_MAXandSAFE_MINconstants (set toNumber.MAX_VALUE / 2) to prevent overflow during calculationsniceMinandniceMaxstay within safe bounds after roundingTesting
Added test cases for both
Number.MAX_VALUEand-Number.MAX_VALUEin datasets to ensure the chart renders without crashing and produces finite scale bounds.