fix: janitor-wave-1

[Kronprinz03]

Changes

• only allow arrays for status in getInstancesByBusinessKey
• using getInstance instead of manual find operation
• removing unused functions

[hyperspace-insights]

The PR makes clean, focused simplifications — narrowing the status parameter to always be an array, delegating to getInstance() internally, and removing the clear() method. The one substantive concern is the removal of clear(): as a singleton exported at module level, localWorkflowStore has no remaining way to reset its state between test runs, risking cross-test contamination. Please address that before merging.

PR Bot Information

Version: 1.18 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

• Correlation ID: 0cdd6a40-1c98-11f1-9d5f-4c4b4f9e8be3
• Event Trigger: issue_comment.created
• LLM: anthropic--claude-4.6-sonnet

[hyperspace-insights]

Bug: Removing clear() breaks test isolation for LocalWorkflowStore

The clear() method was the only way to reset the singleton localWorkflowStore between test runs. Since localWorkflowStore is a module-level singleton, tests that share the same process will accumulate instances across test cases. Without clear(), there is no mechanism to reset state, which can cause cross-test contamination and flaky test results.

Consider retaining the clear() method, or provide an alternative reset mechanism (e.g., a reset() alias) to support test isolation.

Suggested change

	}
	clear(): void {
	this.instances = [];
	}
	}

Double-check suggestion before committing. Edit this comment for amendments.

---

Please provide feedback on the review comment by checking the appropriate box:

• 🌟 Awesome comment, a human might have missed that.
• ✅ Helpful comment
• 🤷 Neutral
• ❌ This comment is not helpful