test(tls): unit tests for the operator-cert manager + handler (4/4)#175
Draft
marceloneppel wants to merge 1 commit into
Draft
test(tls): unit tests for the operator-cert manager + handler (4/4)#175marceloneppel wants to merge 1 commit into
marceloneppel wants to merge 1 commit into
Conversation
This was referenced Jul 1, 2026
marceloneppel
force-pushed
the
tls-3-manager-events
branch
from
90e7728 to
ab4b0c8
Compare
marceloneppel
force-pushed
the
tls-4-tests
branch
from
4a6ab71 to
af4ffef
Compare
marceloneppel
force-pushed
the
tls-3-manager-events
branch
from
ab4b0c8 to
d59f0ac
Compare
marceloneppel
force-pushed
the
tls-4-tests
branch
from
af4ffef to
5aeebec
Compare
Cover TLSManager live-fetch getters, CA rotation, push, and the TLS events handler (certificate_available / relation_broken / defer paths). Stacked on the manager+events PR whose code these exercise. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
marceloneppel
force-pushed
the
tls-4-tests
branch
from
5aeebec to
5a9fa05
Compare
marceloneppel
force-pushed
the
tls-3-manager-events
branch
from
d59f0ac to
1f84b9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4/4, stacked on tls-3-manager-events. The unit tests for the operator-certificate manager and events handler (the code added in part 3).
What's here (~594 lines)
tests/unit/test_tls_manager.py:TLSManagerlive-fetch getters, CA rotation (rotate_peer_ca/clear_peer_ca),push_tls_files,client_tls_files_on_disk, internal-peer CA/cert generation, and the constructor-injection wiring.tests/unit/test_tls_events.py: theTLSevents handler —certificate_available/relation_brokenrouting, CA rotation on peer-cert, defer-until-ready paths.Split out of part 3 so that PR stays near the ~500-line review target; this is the tip of the TLS stack (the commit consuming charms pin via archive URL). Draft — not ready for review.
(This branch was formerly
tls-manager-wiring/#164, repurposed + renamed totls-4-testsafter the rebalance.)