[WIP] refactor: prepare integration tests for legacy code removal#744
Draft
[WIP] refactor: prepare integration tests for legacy code removal#744
Conversation
… coverage to app-level manager tests
- Drop reactive and charm-metrics integration suites and related helpers/fixtures
- Remove wait_for_reconcile/reconcile-id polling and switch remaining charm tests to outcome-based waits (check-runners)
- Simplify charm integration dependencies by removing reactive-only packages (kombu, pymongo)
- Move metrics validation to github-runner-manager app-level integration tests with local log-file assertions
- Add shared app-level OpenStack and metrics helper modules
- Harden runner SSH key resolution for app-level tests (no brittle ~/.ssh/<runner>.key assumption)
- Improve test config ergonomics by adding reconcile_interval and base_virtual_machines parameters to
create_default_config
- Make planner stub port allocation automatic in start() and remove port wiring from callers
- Keep planner lifecycle coverage in existing test_planner_runner and drop low-value test_manager_service
- Update CI workflows:
- remove deleted charm modules from .github/workflows/integration_test.yaml
- update manager integration matrix in .github/workflows/test_github_runner_manager.yaml
cbartz
force-pushed
the
chore/prepare-tests-for-legacy-removal-ISD-4104
branch
from
8947ea4 to
2dc3779
Compare
Contributor
TICS Quality Gate✔️ Passedgithub-runner-operatorSee the results in the TICS Viewer The following files have been checked for this project
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adapt the integration tests:
Rationale
Prepare the removal of the legacy (non-pressure driven reconcile) reconcile mode. Some integration tests relied on specifics of the legacy reconcile mode. The removal of the legacy mode will be done in a separate PR .
Checklist
urgent,trivial,complex).github-runner-manager/pyproject.toml.