Open
Conversation
yhaliaw
reviewed
Jan 20, 2026
| on: | ||
| pull_request: | ||
| issue_comment: | ||
| types: [created] |
Collaborator
There was a problem hiding this comment.
Does this mean, each trigger of e2e run requires a new comment?
I am unsure if this is a good approach, since it might mean we need to spam the PR with comments.
Collaborator
There was a problem hiding this comment.
I think the alt option is to if there is a PR comment that contains the run e2e ci string, then the e2e tests are ran.
E.g., once the PR is almost ready for review we add that comment and see if e2e test is working, and try to fix it on subsequent commits. If e2e tests are not needed for whatever reason, we can just delete the comment.
Contributor
TICS Quality Gate✔️ Passedgithub-runner-operatorSee the results in the TICS Viewer The following files have been checked for this project
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
issue_commenttrigger.Required E2E Test Status Checksalready exists on a repository level, hence this can be safely implemented.Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
urgent,trivial,complex).github-runner-manager/pyproject.toml.No code changes, ci changes only.