fix(coverage-ios): support universal binaries and fix podspec metadata#135
Merged
V3RON merged 1 commit intoJun 3, 2026
Merged
Conversation
|
@mfazekas is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
Pass -arch to llvm-cov export when the app binary is a universal/fat Mach-O (simulator builds with arm64 + x86_64), preferring arm64. Add author and homepage to coverage-ios package.json so the HarnessCoverage podspec passes CocoaPods validation.
bf9daf0 to
f1c430c
Compare
V3RON
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues that prevent native iOS coverage from working.
llvm-cov exportfailed on universal (fat) binaries with-arch specifier is invalid or missing. We now detect multi-arch binaries vialipo -archsand pass-arch(preferringarm64); single-arch binaries are unaffected.HarnessCoveragepodspec failed CocoaPods validation becausecoverage-ios/package.jsonlackedauthorandhomepage. Added both fields.