fix(check): honor Vitest worker configuration - #2437
Conversation
|
Coverage completed 10,034 tests and failed only the unchanged |
|
No code findings at bce5469. Removing the command-line override correctly leaves worker sizing with Vitest configuration, and the regression assertions cover that boundary. The Coverage failure looks unrelated: it runs Vitest directly, not check:affected, and failed an unchanged readiness assertion by one millisecond. Ready for human review; a green Coverage rerun is still needed before merge. |
|
Please fix coverage |
Summary
AGENT_DEVICE_VITEST_MAX_WORKERSconfigures Vitest, butcheck:affectedappended--maxWorkers=4, overriding it. Delegate worker sizing tovitest.config.tsso its default, validated local override, CPU clamp, and CI policy apply. This completes the propagation boundary introduced in #1964.Also address the maintainer's Coverage request by freezing the default readiness-budget test's clock. Its exact 120,000 ms assertion was racing real time across async mock calls. The test now uses the same clock discipline as its neighboring deadline cases.
Four files, +24/−29; the review follow-up adds only the readiness test fix.
Validation
Tested commit:
704b15b87e47b72765bd18bc5aafb269abdf0d53(Node 24.13.1, pnpm 11.17.0, Linux).pnpm check:affected:test: 65 passed.AGENT_DEVICE_VITEST_MAX_WORKERS=1 pnpm check:affected --run: all runnable gates passed, including build, lint, types, package, integration, and compatibility checks.main(umask0077masks file mode; fabricated PID 101 is live here). Readiness: eight passed under instrumentation.