refactor(move): move the remaining package-ready modules out of src/core - #2401
Merged
Conversation
- validation.ts -> @agent-device/kernel/validation - android-system-surface-disclosure.ts -> @agent-device/contracts/android-system-surface-disclosure - project-runtime.ts -> @agent-device/host-kit/project-runtime - runtime-transport-hints(.test).ts -> @agent-device/host-kit/runtime-transport-hints - app-events.ts (+tests) -> src/daemon/app-events.ts - dispatch-payload.ts (+test), payload-input.ts -> src/daemon/ - fill-backend-result.ts (+test) -> src/daemon/ interaction-outcome.ts stays in core: it correlates ResolvedInteractionTarget with error objects across the commands(rank3)/daemon(rank4) boundary, and contracts explicitly refuses mutable interaction-outcome lifecycle (R18).
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
Looks good at 820146b. The module moves preserve implementation behavior, and consumers, package exports and test paths follow the new owners. All current checks pass. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the remaining package-ready modules out of
src/coreinto their owning packages, and the daemon-only helpers next to their single consumer. All moves are rename-only (git diff -M90%shows zero content change on the moved files); the rest is import re-pointing and gate pins. 42 files.validation.ts→@agent-device/kernel/validation(point/integer validators used by 8 runtime files)android-system-surface-disclosure.ts→@agent-device/contracts/android-system-surface-disclosure(agent-facing disclosure, beside the otherandroid-*contract vocabulary)project-runtime.ts→@agent-device/host-kit/project-runtime;runtime-transport-hints.ts(+test) →@agent-device/host-kit/runtime-transport-hints(host/transport concerns)app-events.ts(+tests),dispatch-payload.ts(+test),payload-input.ts,fill-backend-result.ts(+test) →src/daemon/(single daemon-zone consumer each)interaction-outcome.tsstays insrc/core: it correlates resolved targets with error objects across the commands(rank 3)/daemon(rank 4) boundary, and R18 forbids a mutable interaction-outcome lifecycle in contracts — no package owns it today.Validation
820146bdfd:pnpm check:affected --runpassed all runnable checks — 758 related test files (5807 tests) green, layering 187/187, fallow clean on 60 changed files, production-exports and wire-compat green.