Skip to content

refactor(move): move the remaining package-ready modules out of src/core - #2401

Merged
thymikee merged 2 commits into
mainfrom
refactor/core-remaining-module-sweep
Sep 8, 2026
Merged

refactor(move): move the remaining package-ready modules out of src/core#2401
thymikee merged 2 commits into
mainfrom
refactor/core-remaining-module-sweep

Conversation

@thymikee

@thymikee thymikee commented Sep 8, 2026

Copy link
Copy Markdown
Member

Summary

Moves the remaining package-ready modules out of src/core into their owning packages, and the daemon-only helpers next to their single consumer. All moves are rename-only (git diff -M90% shows zero content change on the moved files); the rest is import re-pointing and gate pins. 42 files.

  • validation.ts@agent-device/kernel/validation (point/integer validators used by 8 runtime files)
  • android-system-surface-disclosure.ts@agent-device/contracts/android-system-surface-disclosure (agent-facing disclosure, beside the other android-* contract vocabulary)
  • project-runtime.ts@agent-device/host-kit/project-runtime; runtime-transport-hints.ts (+test) → @agent-device/host-kit/runtime-transport-hints (host/transport concerns)
  • app-events.ts (+tests), dispatch-payload.ts (+test), payload-input.ts, fill-backend-result.ts (+test) → src/daemon/ (single daemon-zone consumer each)
  • interaction-outcome.ts stays in src/core: it correlates resolved targets with error objects across the commands(rank 3)/daemon(rank 4) boundary, and R18 forbids a mutable interaction-outcome lifecycle in contracts — no package owns it today.
  • Re-pointed 22 consumer imports; updated the macOS coverage-manifest owner path, the host-kit export pin, and the contracts exports snapshot.

Validation

  • 820146bdfd: pnpm check:affected --run passed all runnable checks — 758 related test files (5807 tests) green, layering 187/187, fallow clean on 60 changed files, production-exports and wire-compat green.
  • No CLI, wire, or device-visible behavior change: all moved modules are internal, and every moved test file ran green at its new path.

- validation.ts            -> @agent-device/kernel/validation
- android-system-surface-disclosure.ts -> @agent-device/contracts/android-system-surface-disclosure
- project-runtime.ts       -> @agent-device/host-kit/project-runtime
- runtime-transport-hints(.test).ts -> @agent-device/host-kit/runtime-transport-hints
- app-events.ts (+tests)   -> src/daemon/app-events.ts
- dispatch-payload.ts (+test), payload-input.ts -> src/daemon/
- fill-backend-result.ts (+test) -> src/daemon/

interaction-outcome.ts stays in core: it correlates ResolvedInteractionTarget
with error objects across the commands(rank3)/daemon(rank4) boundary, and
contracts explicitly refuses mutable interaction-outcome lifecycle (R18).
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.51 MB 4.51 MB +250 B
Package (unpacked) 4.51 MB 4.51 MB +250 B
Package (download) 1.34 MB 1.34 MB +48 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.1 ms 25.9 ms -0.2 ms
CLI --help 75.9 ms 73.0 ms -2.8 ms

@thymikee

thymikee commented Sep 8, 2026

Copy link
Copy Markdown
Member Author

Looks good at 820146b. The module moves preserve implementation behavior, and consumers, package exports and test paths follow the new owners. All current checks pass.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 8, 2026
@thymikee
thymikee merged commit 22a46d1 into main Sep 8, 2026
18 of 19 checks passed
@thymikee
thymikee deleted the refactor/core-remaining-module-sweep branch September 8, 2026 19:50
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-08 19:50 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant