refactor(move): move lease scope vocabulary into @agent-device/contracts - #2380
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
The move at 54d5057 does not integrate cleanly with current main: CI picks up test/integration/provider-scenarios/remote-proxy-parity.test.ts, which still imports the deleted src/core/lease-scope.ts. Update that consumer to @agent-device/contracts/lease-scope when bringing the branches together, then rerun the affected checks. The missing-module failures in Typecheck & Package, Repo Guards, Integration Tests, and Coverage are directly related to this integration gap; the separate Apple snapshot timeout looks unrelated. |
…cope-contracts * origin/main: (25 commits) fix(ios): avoid duplicate alert routing queries (#2398) docs(adr): record the #2278 coupling audit and re-trace entry-to-platform hops (#2355) chore(gates): classify #2278 daemon-platform-runtime edges and ratchet handler session authority (#2354) test(capture): shrink the 3x crop fixture to avoid coverage timeouts (#2399) perf(ios): settle the first interaction on a deadline, not a fixed sleep (#2395) feat: support standalone Maestro clearState command (#2366) refactor(capture-kit): complete ADR 0019 end state — relocate snapshot and recording zones (#2385) refactor(ios): delete the unused snapshot plan interface (#2392) fix(conformance): isolate post-tap settling from app launch (#2390) test(remote): assert the proxied snapshot's whole wire conversation (#2387) fix(daemon): stop an attested tenant from downgrading its own isolation (#2386) refactor(ios): prune converged snapshot paths (#2383) refactor(move): move the batch runner and batch policy into @agent-device/command-registry (#2388) fix(remote): let a plain-session client read its own failure record (#2382) refactor(move): move replay divergence vocabulary into @agent-device/ad-replay (#2384) refactor(cli): take the CLI's vocabulary off runtime barrels (#2379) perf(cli): keep scroll vocabulary off gesture runtime (#2378) chore: drop the stale planned-operations closure approval (#2373) fix(gates): stop an eager-closure approval from turning main red on merge (#2375) fix(ios): honor the startup budget through a cold Simulator boot (#2325) ...
The test landed on main after this branch cut and still imported the pre-move path src/core/lease-scope.ts; use the @agent-device/contracts/lease-scope subpath like the other consumers.
Member
Author
|
Looks good at 0fd89d5. The remote-proxy integration test now uses the new lease-scope import, and the remaining changes preserve behavior. All current checks pass. |
thymikee
added
the
ready-for-human
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move 1 of the
src/core-> owning-package sweep (#2335):src/core/lease-scope.tsand its unit test move to@agent-device/contractsbehind a new./lease-scopesubpath. Pure file move with zero content change (git rename detection at 100%); the consumers (src/daemon,src/daemon-client,src/commands,src/client,src/remote) now import@agent-device/contracts/lease-scope. Gate pins follow the file: wire-compat surface/ledger key and the contracts exports snapshot.Validation
pnpm check:affected --runat0fd89d54b9: all runnable checks passed (format, lint, typecheck, layering, di-seams, fallow, mcp-metadata, build, package, integration-node, macos-coverage, vitest-related 355 files / 2766 tests, integration-progress, replay-compat, daemon-wire-compat, affected-selector).check:daemon-wire-compat: the lease-scope declaration is a clean move, no removal.git diff -M90% --stat origin/main...HEAD: moved file and test are pure renames; every other hunk is an import re-point.origin/mainafter the initial green run: it addedremote-proxy-parity.test.tsreferencing the pre-move path, re-pointed to the contracts subpath in the same branch.