Repository navigation
feat: processor engines get http-nu's context-free commands (.mj etc.) - #48
Merged
Merged
Conversation
cablehead
force-pushed
the
feat/engine-base
branch
from
June 20, 2026 13:28
14e0b4d to
b460336
Compare
cablehead
force-pushed
the
feat/engine-base
branch
from
August 7, 2026 15:03
29bff84 to
b42e64e
Compare
cablehead
force-pushed
the
feat/engine-base
branch
from
September 29, 2026 19:06
b42e64e to
d16aeed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hand the xs processors (actor, service, action) a base engine with http-nu's
.mj,.md, and highlight commands, so they work in a service or actor, not just an HTTP handler.Engine::add_processor_commands(&store): store-backed.mj/.mj compile,.mj render,.md,.highlight*.Store::initsets this base before the processors spawn;prepared_baseclones it per spawn.Why
.mjwas registered only on the HTTP engine, so using it in a service failed. Model: xs ADR 0007.Notes
Store::with_base_engine, released in cross-stream 0.14.0, which main now depends on. Rebased onto main; the temporary xs branch pin and the 0.13.4 repoint are gone, so this PR no longer touchesCargo.tomlorCargo.lock.Engine::newsplit: main's is already clean.test_processor_base_command_surface.http-nu eval --store --services: an actor calling.mdemitsmd.outwith the rendered HTML. On main the same actor fails with "Command.mdnot found".