Skip to content

wstd::http_server: don't panic after setting responder.fail #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchickey merged 1 commit into from
Jan 15, 2026
Merged

wstd::http_server: don't panic after setting responder.fail #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions macro/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,9 @@ pub fn attr_macro_http_server(_attr: TokenStream, item: TokenStream) -> TokenStr
match ::wstd::http::request::try_from_incoming(request) {
Ok(request) => match __run(request) #run_await {
Ok(response) => { responder.respond(response).await.unwrap() },
Err(err) => responder.fail(err).unwrap(),
Err(err) => responder.fail(err),
}
Err(err) => responder.fail(err).unwrap(),
Err(err) => responder.fail(err),
}
})
}
Expand Down
3 changes: 1 addition & 2 deletions src/http/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,11 @@ impl Responder {

/// This is used by the `http_server` macro.
#[doc(hidden)]
pub fn fail(self, err: Error) -> Result<(), Error> {
pub fn fail(self, err: Error) {
let e = match err.downcast_ref::<ErrorCode>() {
Some(e) => e.clone(),
None => ErrorCode::InternalError(Some(format!("{err:?}"))),
};
ResponseOutparam::set(self.outparam, Err(e));
Err(err)
}
}