[C#] Remove WaitableSet and its global. Tidy <T> in codegen#1552
Merged
dicej merged 2 commits intobytecodealliance:mainfrom Mar 10, 2026
Merged
[C#] Remove WaitableSet and its global. Tidy <T> in codegen#1552dicej merged 2 commits intobytecodealliance:mainfrom
dicej merged 2 commits intobytecodealliance:mainfrom
Conversation
dicej
approved these changes
Mar 9, 2026
Collaborator
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
LGTM overall; just a few (optional) comments inline.
| } | ||
|
|
||
| public static Task<T> TaskFromStatus<T>(uint status, Func<T> liftFunc) | ||
| public static unsafe Task<T> TaskFromStatus<T>(uint status, Func<T> liftFunc) |
Collaborator
There was a problem hiding this comment.
What makes this function unsafe to call? Could it be documented?
crates/csharp/src/AsyncSupport.cs
Outdated
| { | ||
| Console.WriteLine("FutureReader Read Blocked creating WaitableSet"); | ||
| AsyncSupport.WaitableSet = AsyncSupport.WaitableSetNew(); | ||
| contextTaskPtr = (ContextTask *)Marshal.AllocHGlobal(Marshal.SizeOf<ContextTask>()); |
Collaborator
There was a problem hiding this comment.
These same three lines appear in several places; might want to consider adding a helper function which encapsulates them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the disposable WaitableSet class and the global, replacing it with
ContextSet/ContextGetCloses #1550