Skip to content

Handle OOM in Engine::new#12362

Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen:handle-oom-in-engine-new
Jan 21, 2026
Merged

Handle OOM in Engine::new#12362
fitzgen merged 1 commit intobytecodealliance:mainfrom
fitzgen:handle-oom-in-engine-new

Conversation

@fitzgen
Copy link
Member

@fitzgen fitzgen commented Jan 15, 2026

Part of #12069

Depends on #12361

@fitzgen fitzgen requested review from a team as code owners January 15, 2026 19:39
@fitzgen fitzgen requested review from alexcrichton and removed request for a team January 15, 2026 19:39
@fitzgen fitzgen force-pushed the handle-oom-in-engine-new branch from 420d352 to 62d45c5 Compare January 15, 2026 20:48
@github-actions github-actions bot added fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Jan 15, 2026
@github-actions
Copy link

Subscribe to Label Action

cc @fitzgen

Details This issue or pull request has been labeled: "fuzzing", "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions
Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Details

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    Details

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


Details

To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@fitzgen fitzgen force-pushed the handle-oom-in-engine-new branch 2 times, most recently from 0386569 to 1eb7c02 Compare January 20, 2026 21:56
@fitzgen fitzgen added this pull request to the merge queue Jan 21, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jan 21, 2026
@fitzgen fitzgen force-pushed the handle-oom-in-engine-new branch from 1eb7c02 to c40cb25 Compare January 21, 2026 19:23
@fitzgen fitzgen enabled auto-merge January 21, 2026 19:23
@fitzgen fitzgen added this pull request to the merge queue Jan 21, 2026
Merged via the queue into bytecodealliance:main with commit a052569 Jan 21, 2026
45 checks passed
@fitzgen fitzgen deleted the handle-oom-in-engine-new branch January 21, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fuzzing Issues related to our fuzzing infrastructure wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants