Fix Module::display to print function bodies again#10
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom Feb 25, 2026
Merged
Fix Module::display to print function bodies again#10cfallin merged 1 commit intobytecodealliance:mainfrom
Module::display to print function bodies again#10cfallin merged 1 commit intobytecodealliance:mainfrom
Conversation
The change which added `PrintDecorator` broke the default `Module::display` by not showing the function bodies anymore when no `PrintDecorator` was provided. This change always invokes the body display function again, now with the optional `PrintDecorator`.
Contributor
Author
|
I also saw that I can make a follow-up PR with this change if you're welcome to it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change which added
PrintDecoratorbroke the defaultModule::displayby not showing the function bodies anymore when noPrintDecoratorwas provided.This change always invokes the body display function again, now with the optional
PrintDecorator.This does change the signature of
FunctionBody::display_with_decoratorto take anOption<&'a PD>now, which is not consistent with the function convention onModule, but this needs a display function on FunctionBody which takes anOption.Alternatively I can change this to invoke
FunctionBody::displayorFunctionBody::display_with_decoratordepending on the presence/absence of a decorator, but that feels less ideal.