Add support for inserting new bullets mid-line#158
Closed
cdalizadeh wants to merge 7 commits intobullets-vim:masterfrom
Closed
Add support for inserting new bullets mid-line#158cdalizadeh wants to merge 7 commits intobullets-vim:masterfrom
cdalizadeh wants to merge 7 commits intobullets-vim:masterfrom
Conversation
cdalizadeh
commented
Feb 23, 2025
| end | ||
|
|
||
| it 'supports nested dot bullets' do | ||
| pending('FIXME: this test fails, but the functionality works') |
Author
There was a problem hiding this comment.
This line was causing tests to fail. Happy to add it back if needed.
cdalizadeh
force-pushed
the
cdalizadeh/mid-line-new-bullets
branch
from
e296418 to
167140b
Compare
Collaborator
|
This appears to be failing after the most recent changes. Could you take a look? I can merge once tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behaviour is that calls to
insert_new_bullet()while the cursor is in the middle of the line (in insert mode) do not insert a bullet in the newly created line. This behaviour differs from most word processors, which insert a new bullet when enter is pressed mid-line. This PR modifiesinsert_new_bullet()to a insert a bullet in the newly created line when called from the middle of the line in insert mode.Previous behaviour:
New behaviour: