Draft
Conversation
…r be used as the entry point
Contributor
Author
|
Question for the team: We've talked about potentially deprecating support for Internet Explorer. Given that we have 4 modules testing for different versions, should we:
|
Contributor
I think we can leave them as-is since someone else might be able to find those useful. |
jplukarski
requested changes
Jan 4, 2024
Contributor
jplukarski
left a comment
There was a problem hiding this comment.
Can you merge in main and resolve the conflicts? Also, how close is this draft PR to being ready for review?
jjmcintyre1
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
Summary
/srcdirectory.index.tsfile as the entry point to the library. This is a breaking change, and the import statements to use our modules will now change:import { isChrome, isSafari } from @braintree/browser-detectiondistdirectory directly from the source code.Why Vitest
Vitest is a "blazingly fast" unit test framework, and allows us to leave the test suite running in a watch-mode environment while we continue to make changes to our code. Only the necessary tests will re-run depending on what files were changed, making it much quicker to make changes without having to wait for the entire test suite to re-run.
Vitest has also been designed with a Jest compatible API, in order to make the migration from Jest as simple as possible. The API is essentially the same as Jest with some very minor differences.
Why Create
index.tsas the entry pointdistfolder from the source codeChecklist
Authors