Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| .unique()); | ||
|
|
||
| for (int offset_ = -ystart; offset_ <= ystart; ++offset_) { | ||
| const auto region = fmt::format("RGN_YPAR_{:+d}", offset_); |
Contributor
There was a problem hiding this comment.
warning: no header providing "fmt::format" is directly included [misc-include-cleaner]
src/mesh/mesh.cxx:12:
- #include "impls/bout/boutmesh.hxx"
+ #include "fmt/format.h"
+ #include "impls/bout/boutmesh.hxx"
ZedThree
previously approved these changes
Mar 9, 2026
dschwoerer
dismissed
ZedThree’s stale review
The merge-base changed after approval.
to set default regions for parallel slices
dschwoerer
force-pushed
the
parallel-regions
branch
from
4a63baf to
0513875
Compare
ZedThree
reviewed
Mar 11, 2026
Co-authored-by: Peter Hill <peter.hill@york.ac.uk>
bendudson
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets valid regions for the parallel slices.
Includes #3296