deps: Update containers-image-proxy to 0.10.0#2188
deps: Update containers-image-proxy to 0.10.0#2188jeckersb wants to merge 2 commits intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, including upgrading composefs-related crates to version 0.4.0 and containers-image-proxy to version 0.10.0. Key changes include renaming the cfsctl package to composefs-ctl and replacing cstorage with composefs-storage. The codebase was also refactored to initialize ImageProxyConfig using Default::default() followed by field assignments, likely due to upstream struct changes. I have no feedback to provide as no review comments were present.
| # cfsctl = { path = "/path/to/composefs-rs/crates/cfsctl" } | ||
| # The Justfile will auto-detect these and bind-mount them into container builds. | ||
| cfsctl = { git = "https://github.com/composefs/composefs-rs", rev = "54d248f7a7", package = "cfsctl" } | ||
| cfsctl = { git = "https://github.com/composefs/composefs-rs", rev = "4dd43a107e", package = "composefs-ctl" } |
There was a problem hiding this comment.
Potentially we should split out composefs into its own dependabot group because it's far more impactful
containers-image-proxy 0.10.0 bumps its oci-spec dependency from 0.8 to 0.9. This required a cascade of dependency updates to avoid having two incompatible versions of oci-spec in the dependency graph: - ocidir 0.7.0 → 0.7.2 (adds oci-spec 0.9 support) - composefs-rs rev 54d248f7a7 → 4dd43a107e (0.3.0 → 0.4.0, which also uses containers-image-proxy 0.10 and oci-spec 0.9). The package was also renamed from cfsctl to composefs-ctl. Adapted to breaking API changes in containers-image-proxy (ImageProxyConfig is now #[non_exhaustive]). Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: John Eckersberg <jeckersb@redhat.com>
|
Updated docs CI to reflect cfsctl -> composefs-ctl change |
|
Added a commit for bulk rename from cfsctl -> composefs-ctl per gemini feedback in #2189 (comment) |
The upstream composefs-rs package was renamed from cfsctl to composefs-ctl in 0.4.0. Update the workspace dependency key to match, removing the need for the `package` field, and rename all Rust imports from cfsctl:: to composefs_ctl::. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: John Eckersberg <jeckersb@redhat.com>
|
any chance we can get composefs/composefs-rs@96a9661 in this? |
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
|
We're hitting rate limit for dockerhub |
|
Yeah at some point we may need to just always fetch mirrored images from ghcr.io... |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
4 participants
containers-image-proxy 0.10.0 bumps its oci-spec dependency from
0.8 to 0.9. This required a cascade of dependency updates to avoid
having two incompatible versions of oci-spec in the dependency graph:
also uses containers-image-proxy 0.10 and oci-spec 0.9). The
package was also renamed from cfsctl to composefs-ctl.
Adapted to breaking API changes in containers-image-proxy (ImageProxyConfig
is now #[non_exhaustive]).
Assisted-by: OpenCode (claude-opus-4-6)
Signed-off-by: John Eckersberg jeckersb@redhat.com