Set the target image reference for the bink node#57
Merged
Conversation
Collaborator
Author
|
We still have some mismatch with the digest. So, it is expected that the test failed, but the PR is ready for review. The problem is on bink |
jlebon
reviewed
Jun 9, 2026
Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alicefr
force-pushed
the
updates
branch
3 times, most recently
from
d786743 to
e54b66a
Compare
jlebon
approved these changes
Jun 11, 2026
jlebon
left a comment
jlebon
left a comment
Collaborator
There was a problem hiding this comment.
Mostly minor comments; LGTM overall!
I filed #60 for the Justfile migration, but probably also eventually we should move a lot of the bink setup stuff to a dedicated hack/ script file to make it more manageable.
Feel free to merge after fixing at least the non-optional comments.
Seed the bink registry with the bootc image from the node disk image so e2e tests can reference real images. Add --target-imgref support to make nodes track the registry image. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verify that the BootcNode booted image and digest match the seeded registry image when available. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move the update image build logic out of e2e test code and into a Makefile target. Build the update image as part of deploy-bink so it is available for both manual testing and e2e tests. Assisted-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overwrite the node image reported by
bootc statusto the image pushed in the local registry. Also, it infers the digest of the node image from the label stored on the node disk image.Additionally, this PR prepares a second image for the testing of the update. It generates a second image starting from the node image and push it to the local registry