fix(builtins/array,string/mod.rs): convert panics to EngineError::Panic using js_expect#5007
Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom Mar 12, 2026
Conversation
Converts .expect() panics in array/mod.rs, array/from_async.rs, and string/mod.rs to use JsExpect trait for graceful host recovery. Part of boa-dev#3241.
Test262 conformance changes
Fixed tests (2):Broken tests (182):Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5007 +/- ##
===========================================
+ Coverage 47.24% 58.42% +11.17%
===========================================
Files 476 559 +83
Lines 46892 61402 +14510
===========================================
+ Hits 22154 35872 +13718
- Misses 24738 25530 +792 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
approved these changes
Mar 12, 2026
jedel1043
added
A-Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3241.
It changes the following:
core/engine/src/builtins/array/mod.rs: converted 20 panics (ArrayCreate,CreateDataPropertyOrThrow,ToUint32,Set,ToObject,as_object,OrdinaryDefineOwnProperty) to use?orjs_expectcore/engine/src/builtins/array/from_async.rs: converted 5 panics (resolve/reject.call()on promise resolving functions) to usejs_expectcore/engine/src/builtins/string/mod.rs: converted 4 panics (GetSubstitution,to_integer_or_infinity,downcast_ref::<Collator>,as_objectinget_substitution) to usejs_expect