fix(lexer): replace unimplemented! with syntax error for unknown oper…#4985
Open
tkshsbcue wants to merge 2 commits intoboa-dev:mainfrom
Open
fix(lexer): replace unimplemented! with syntax error for unknown oper…#4985tkshsbcue wants to merge 2 commits intoboa-dev:mainfrom
tkshsbcue wants to merge 2 commits intoboa-dev:mainfrom
Conversation
…ators When the operator lexer encounters an unexpected byte, return Err(Error::syntax(...)) instead of panicking. Made-with: Cursor
tkshsbcue
force-pushed
the
fix/operator-lexer-unimplemented-to-error-v2
branch
from
b1d4f48 to
74ef259
Compare
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4985 +/- ##
===========================================
+ Coverage 47.24% 58.53% +11.28%
===========================================
Files 476 560 +84
Lines 46892 61709 +14817
===========================================
+ Hits 22154 36119 +13965
- Misses 24738 25590 +852 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
added
C-Parser
Member
|
You don't need to merge if you don't have merge conflicts by the way, our merge queue already resolves those. |
Contributor
Author
|
Sorry my bad @jedel1043 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(lexer): replace unimplemented! with syntax error for unknown operators
Replace
unimplemented!("operator {}", op)in the operator lexer withErr(Error::syntax(...)). Unknown operator bytes now produce a recoverable syntax error instead of panicking.