feat(intl): implement ChainDateTimeFormat and UnwrapDateTimeFormat#4972
Open
xcb3d wants to merge 2 commits intoboa-dev:mainfrom
Open
feat(intl): implement ChainDateTimeFormat and UnwrapDateTimeFormat#4972xcb3d wants to merge 2 commits intoboa-dev:mainfrom
xcb3d wants to merge 2 commits intoboa-dev:mainfrom
Conversation
Implement the normative optional constructor mode for Intl.DateTimeFormat per ECMA-402 §11.1.2 and §11.1.1: - ChainDateTimeFormat: When called without on a DateTimeFormat instance, store the new format via the [[FallbackSymbol]] property and return , matching legacy constructor behavior. - UnwrapDateTimeFormat: Resolve the underlying DateTimeFormat from objects that may have been chained, used by both and . This mirrors the existing NumberFormat implementation for consistency.
Test262 conformance changes
Tested main commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4972 +/- ##
===========================================
+ Coverage 47.24% 58.39% +11.14%
===========================================
Files 476 556 +80
Lines 46892 61180 +14288
===========================================
+ Hits 22154 35725 +13571
- Misses 24738 25455 +717 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedel1043
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request resolves the TODO comment "Should we support the ChainDateTimeFormat?" in
date_time_format/mod.rs.It changes the following:
ChainDateTimeFormat(ECMA-402 §11.1.1.1) in theIntl.DateTimeFormatconstructorUnwrapDateTimeFormat(ECMA-402 §11.5.14) abstract operationget formatandresolvedOptionsto useUnwrapDateTimeFormat