Add Latin1 Encoding Check in from Method#4945
Open
rajat552 wants to merge 3 commits intoboa-dev:mainfrom
Open
Conversation
Test262 conformance changes
Tested main commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4945 +/- ##
===========================================
+ Coverage 47.24% 57.95% +10.71%
===========================================
Files 476 557 +81
Lines 46892 60962 +14070
===========================================
+ Hits 22154 35331 +13177
- Misses 24738 25631 +893 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@jedel1043 review this PR let me know if any changes required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a check for Latin1 encoding in the
frommethod of theJsStringimplementation. Previously, the method only handled ASCII strings, but this update extends support to strings containing characters within the Latin1 range (0x00to0xFF).Changes
frommethod to handle Latin1-compatible strings by converting them toJsStr::latin1.Testing
Impact
This change improves string handling by allowing the
frommethod to support Latin1-encoded strings. As a result, the implementation becomes more robust and capable of handling a wider range of character inputs efficiently.Closes #4944