bdb thread locking info is same now for both rdonly and rdwr#5910
bdb thread locking info is same now for both rdonly and rdwr#5910dorinhogea wants to merge 1 commit intobloomberg:mainfrom
Conversation
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
sirace [setup failed with core dumped]
catchup_idle [setup failed with core dumped]
cinsert_linearizable [setup failed with core dumped]
maxtable [setup failed with core dumped]
socksql_master_swings [setup failed with core dumped]
truncatesc [setup failed with core dumped] **quarantined**
phys_rep_tiered [setup failed with core dumped]
phys_rep_tiered_nosource_generated [setup failed with core dumped]
phys_rep_tiered_firstfile_generated [setup failed with core dumped]
truncatesc_offline_generated [setup failed with core dumped] **quarantined**
Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
remsql_locks_rte_connect_generated **quarantined**
remsql_locks **quarantined**
reco-ddlk-sql [timeout] **quarantined**
|
In case it is not clear (look at bdb_thread_event), the changed code does not LOCK, it only prepares the thread for later locking. Originally, we used to do things different depending on the flag. That is not true anymore.
|
|
|
||
| switch (event) { | ||
| case BDBTHR_EVENT_DONE_RDONLY: /* thread done */ | ||
| case BDBTHR_EVENT_DONE: /* thread done */ |
There was a problem hiding this comment.
This is the important part; rdonly and rdwr are identical
/plugin-branch onebdblock