{173778048} Count fix#5834
Open
chands10 wants to merge 3 commits intobloomberg:mainfrom
Open
Conversation
Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
Contributor
Author
|
Same as #4133 But I can't get robor to pick up that pr |
roborivers
suggested changes
Mar 23, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
scindex_logicalsc_generated
sc_resume_logicalsc_generated **quarantined**
reco-ddlk-sql **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
remsql_locks_rte_connect_generated **quarantined**
remsql_locks **quarantined**
truncatesc_offline_generated [timeout] **quarantined**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit by commit
For first commit:
bdb_count doesn't use dta if no indices are available, led to seg fault. Instead of calling bdb_count_int call bdb_direct_count_int which does use dta if no index available.
Wrote robomark test direct_count for this
For second commit:
bdb_count_int had an optimization to find count using recnums first. Port that over to bdb_direct_count_int
Ported code and cleaned up into functions from https://github.com/bloomberg/comdb2/blob/main/bdb/count.c#L66
DIFFERENCE: DB_REP_HANDLE_DEAD isn't set to BDB_ERR_DEADLOCK anymore. Don't think this would ever be a possible rc though since locks acquired before calling bdb_direct_count_int?