Feat: Add user agent prefix string#72
Draft
pniedzielski wants to merge 1 commit intobloomberg:mainfrom
Draft
Conversation
pniedzielski
force-pushed
the
feat/user-agent
branch
from
f469601 to
d052014
Compare
The BlazingMQ broker and C++ SDK recently gained the ability to use a user agent string during session negotiation for more precise broker telemetry of sessions. One of the primary drivers of this new capability was to be able to distinguish Python `blazingmq` sessions, which wrap `libbmq`, from applications that directly use `libbmq`. This patch makes good on that promise by teaching `blazingmq` to set the a user agent prefix, and to expose a session option for any further libraries that may wrap the Python SDK. Applications that are implemented on top of this library will start sending a user agent string of the form `blazingmq(python3.9):1.3.0 libbmq:99.99.99`, containing the Python interpreter version of the application, the version of the `blazingmq` Python library, and the version of the `libbmq` C++ library on which `blazingmq` was built. Signed-off-by: Patrick M. Niedzielski <pniedzielski@bloomberg.net>
pniedzielski
force-pushed
the
feat/user-agent
branch
from
d052014 to
b6cd550
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BlazingMQ broker and C++ SDK recently gained the ability to use a user agent string during session negotiation for more precise broker telemetry of sessions. One of the primary drivers of this new capability was to be able to distinguish Python
blazingmqsessions, which wraplibbmq, from applications that directly uselibbmq.This patch makes good on that promise by teaching
blazingmqto set the a user agent prefix, and to expose a session option for any further libraries that may wrap the Python SDK. Applications that are implemented on top of this library will start sending a user agent string of the formblazingmq(python3.9):1.3.0 libbmq:99.99.99, containing the Python interpreter version of the application, the version of theblazingmqPython library, and the version of thelibbmqC++ library on whichblazingmqwas built.Closes: #71