chore(desktop): upgrade Radix context menu - #6868
Draft
matt2e wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Jitter <d14dfe033ef0f809866f9f984de04821b0d900d7652fd85a54776ee40ca3a68f@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Move to sectionsubmenu in a channel context menu was observed flickering/disappearing briefly during startup, then settling after roughly 30 seconds. The behavior was not reproducible on currentmain, so this is a best-fit mitigation rather than a claim that the root cause is proven.Buzz uses React 19. Radix issue #3963 documents an intermittent React 19 infinite re-render loop caused by unstable composed-ref identities, including in
MenuSubTrigger. Radix menu 2.1.19 includes the corresponding fix; this upgrade moves Buzz through that fix to 2.1.24.Related issue
buzz-move-to-disappears, event6ca216a355313fe032852f250cbafe1d40814382cbc2d0b7059dbac13038f398.Behavior changes
Radix's intervening context-menu releases intentionally change a few edge behaviors: menus now close when the window loses focus, an already-open menu reanchors to a subsequent context-menu event, long-press submenu state resets correctly, and Space/Enter from focusable descendants is no longer intercepted. No Buzz API changes were required, and 2.3.7 reverts the React Server Component compatibility regression from intermediate releases.
Because the dependency backs Buzz's shared desktop context-menu wrapper, these behavior fixes apply to all desktop context menus, not only the channel menu.
Testing
./bin/just ciMove to sectionsubmenus both remained open through delayed capability loading, accepted pointer movement into the submenu, and completed the channel move.