Conversation
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
7af0b81 to
c19faae
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7430 +/- ##
==========================================
+ Coverage 58.53% 58.74% +0.21%
==========================================
Files 2069 2071 +2
Lines 91306 91264 -42
Branches 8128 8129 +1
==========================================
+ Hits 53443 53615 +172
+ Misses 35954 35733 -221
- Partials 1909 1916 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kdenney
left a comment
There was a problem hiding this comment.
Logic looks good! Only thing I'd ask is if you could add some unit tests to cover the new changes? We've had issues in the past with changes to the licensing logic causing regressions so I like to make sure we cover that area pretty thoroughly. Thanks!
| { | ||
| ValidateIssuerSigningKey = true, | ||
| IssuerSigningKey = new X509SecurityKey(_certificate), | ||
| IssuerSigningKey = issuerKey, |
There was a problem hiding this comment.
| IssuerSigningKey = issuerKey, | |
| IssuerSigningKeys =_verificationCertificates.Select((c) => new X509SecurityKey(c)), |
This should also mean you don't need to do any merges since only one would be valid anyways. This just says both of those keys are valid.
kdenney
left a comment
There was a problem hiding this comment.
Approving after our convo in slack. Tests are complicated without giving the licenses to CI. Ideally we refactor this in the future into two services but not needed for this fix.
Co-authored-by: Justin Baur <19896123+justindbaur@users.noreply.github.com>
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR makes three targeted changes to support QA automation in non-production environments. The licensing service is refactored to separate creation and verification certificates, allowing self-hosted dev instances to accept both production-signed and dev-signed licenses. The data protection configuration removes the development early-return so non-production environments can configure key persistence when settings are available, with a null check added to prevent crashes when certificates are absent. The PlayId service broadens its scope from development-only to all non-production environments. The previous review finding regarding |
|





🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34880
https://bitwarden.atlassian.net/browse/PM-34881
https://bitwarden.atlassian.net/browse/PM-34886
📔 Objective
Various tweaks to smooth qa automation testing.
📸 Screenshots