Skip to content

[PM-38808] Support optional encrypted Cipher.name#7048

Open
shane-melton wants to merge 1 commit into
mainfrom
PM-38808/support-optional-cipher-name
Open

[PM-38808] Support optional encrypted Cipher.name#7048
shane-melton wants to merge 1 commit into
mainfrom
PM-38808/support-optional-cipher-name

Conversation

@shane-melton

Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38808

📔 Objective

The SDK is making the encrypted Cipher.name field optional (StringString?) as part of the blob encryption migration (sdk-internal#1122) — blob-encrypted ciphers carry the name inside the sealed data blob rather than as a top-level field.

Cipher.toFailureCipherListView() builds a CipherListView (whose name is non-null) directly from the encrypted Cipher, so the now-nullable name no longer compiles. This falls back to an empty string when the name is absent.

The decrypted CipherView / CipherListView name fields are unchanged, so all UI and sorting is unaffected.

Pairs with the SDK version bump.

Adapts to the SDK making encrypted Cipher.name optional (sdk-internal#1122).
@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label Jun 9, 2026
@shane-melton shane-melton marked this pull request as ready for review June 9, 2026 21:37
@shane-melton shane-melton requested review from a team and david-livefront as code owners June 9, 2026 21:37
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a single-line change in VaultSdkCipherExtensions.kt#toFailureCipherListView that swaps name = name for name = name.orEmpty() to accommodate the SDK's Cipher.name going from String to String? as part of the blob encryption migration. The function is only invoked on undecryptable ciphers (decryptCipherListResult.failures) where the encrypted name is opaque to the UI, so falling back to an empty string is appropriate and non-impactful to sort, filter, and grouping logic on decrypted ciphers. Existing unit tests in VaultSdkCipherExtensionsTest.kt continue to exercise the function across cipher types, and the PR is correctly scoped as a compile-time companion to the SDK version bump.

Code Review Details

No findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant