[PM-38808] Support optional encrypted Cipher.name#7048
Open
shane-melton wants to merge 1 commit into
Open
Conversation
Adapts to the SDK making encrypted Cipher.name optional (sdk-internal#1122).
Contributor
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed a single-line change in Code Review DetailsNo findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-38808
📔 Objective
The SDK is making the encrypted
Cipher.namefield optional (String→String?) as part of the blob encryption migration (sdk-internal#1122) — blob-encrypted ciphers carry the name inside the sealeddatablob rather than as a top-level field.Cipher.toFailureCipherListView()builds aCipherListView(whosenameis non-null) directly from the encryptedCipher, so the now-nullablenameno longer compiles. This falls back to an empty string when the name is absent.The decrypted
CipherView/CipherListViewnamefields are unchanged, so all UI and sorting is unaffected.