OP_CAT to BIP 0003 format, add usecase and test vectors#2090
OP_CAT to BIP 0003 format, add usecase and test vectors#2090murchandamus merged 7 commits intobitcoin:masterfrom
Conversation
EthanHeilman
force-pushed
the
catupdate
branch
from
2fa24ee to
682e1e4
Compare
EthanHeilman
force-pushed
the
catupdate
branch
from
682e1e4 to
e681ec8
Compare
murchandamus
left a comment
murchandamus
left a comment
There was a problem hiding this comment.
If you have have concluded all planned work on this proposal, have you considered advancing this BIP to Complete?
murchandamus
added
the
BIP Update by Owner
|
@murchandamus From a content perspective, I don't plan to add anything else. If @arminsabouri agrees, I see no reason not to mark it as complete. If at some future point, in response to rough consensus we may create an activation client, I plan to document the activation details in this BIP. Rereading BIP 0003, it doesn't say it explicitly, but it seems like the intention is for this to be done after the BIP is complete as part of preparing the BIP for deployed status. I'm I understanding BIP 0003 correctly here? |
|
Ethan wrote:
You’re right, there is so far no explicit guidance regarding when the activation mechanism would be expected or how it should be formatted. Given that any deployment strategy matters only temporarily and doesn’t otherwise impact the content of the Specification, it seems reasonable to me that the activation mechanism may be added after a BIP is moved to Complete. |
|
|
||
| OP_CAT usage in a non-tapscript script will continue to trigger the SCRIPT_ERR_DISABLED_OPCODE. The only change would be to OP_CAT usage in tapscript. This change to tapscript would be activated as a soft fork that redefines an OP_SUCCESSx opcode (OP_SUCCESS126) to OP_CAT. | ||
|
|
||
| ==Reference implementation== |
There was a problem hiding this comment.
Do you feel that this proposal needs test vectors? If so, they should be added/referenced for it to be moved to Complete.
The Elements implementation does appear to have some that could perhaps be adapted: ElementsProject/elements@9fea017
There was a problem hiding this comment.
Good point! The reference implementation does have test vectors. I'll update this PR with them when I get a moment
Co-authored-by: Mark "Murch" Erhardt <murch@murch.one>
|
I noticed that the table entry was not updated along the preamble update, so I added a commit to fix the table entry. |
murchandamus
added
PR Author action required
EthanHeilman
changed the title
|
@murchandamus Added test vectors |
murchandamus
removed
the
PR Author action required
3 participants
Uh oh!
There was an error while loading. Please reload this page.