Enable -Wunused

[fanquake]

If merged, this would be used downstream in bitcoin/bitcoin#36167.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline and AI policy for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #342 (Allow request cancellation for wrapped C++ methods by xyzconstant)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[fanquake]

Not quite sure what is happening here. The job is failing with the following (https://github.com/bitcoin-core/libmultiprocess/actions/runs/34366056349/job/102514949616?pr=362#step:6:253):

Warning: include-what-you-use reported diagnostics:
error: unknown warning option '-Wtrailing-whitespace'; did you mean '-Wunicode-whitespace'? [-Werror,-Wunknown-warning-option]

However -Wtrailing-whitespace already exists in the config on master, so I don't see why the CI would be passing on the master branch, but failing with that issue here. From what I can tell, even though GCC is the compiler being used by CMake (where this flag is supported), include-what-you-use is parsing using Clang, which doesn't support the flag.

[fanquake]

Adding -Wno-unused-command-line-argument fixes the unknown warning option error (that makes sense as a side-effect, given the -Wunused addition), however the job is still failing with IWYU issues, that aren't present on master?