Skip to content

Add first-class service worker builds#263

Merged
bcomnes merged 1 commit into
staic-client-cachefrom
first-class-service-workers
Jun 15, 2026
Merged

Add first-class service worker builds#263
bcomnes merged 1 commit into
staic-client-cachefrom
first-class-service-workers

Conversation

@bcomnes

@bcomnes bcomnes commented Jun 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • detect one site-level service-worker.{js,mjs,cjs,ts,mts,cts} source anywhere under src and report duplicate service-worker sources clearly
  • build the service worker through esbuild to stable /service-worker.js while keeping normal hashed outputs elsewhere
  • add service-worker to the output manifest kind schema and docs
  • update watch mode and fixtures so service worker changes rebundle without page rebuilds

Tests

  • npm run test:tsc
  • npm run test:neostandard
  • npm run test:installed-check
  • npm run test:node-test
  • node --test lib/identify-pages.test.js test-cases/general-features/index.test.js test-cases/watch/index.test.js --test-reporter=spec

Copilot AI review requested due to automatic review settings June 15, 2026 15:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coveralls

coveralls commented Jun 15, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27571997321

Coverage decreased (-0.09%) to 92.784%

Details

  • Coverage decreased (-0.09%) from the base build.
  • Patch coverage: 2 uncovered changes across 1 file (168 of 170 lines covered, 98.82%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
index.js 13 11 84.62%
Total (5 files) 170 168 98.82%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 5164
Covered Lines: 4913
Line Coverage: 95.14%
Relevant Branches: 947
Covered Branches: 757
Branch Coverage: 79.94%
Branches in Coverage %: Yes
Coverage Strength: 121.19 hits per line

💛 - Coveralls

@bcomnes bcomnes force-pushed the first-class-service-workers branch 5 times, most recently from e6d110d to 42bc756 Compare June 15, 2026 19:46
@bcomnes bcomnes force-pushed the first-class-service-workers branch from 42bc756 to 458589a Compare June 15, 2026 19:47
@bcomnes bcomnes merged commit ebe6169 into staic-client-cache Jun 15, 2026
10 checks passed
@bcomnes bcomnes deleted the first-class-service-workers branch June 15, 2026 19:49
bcomnes added a commit that referenced this pull request Jun 15, 2026
bcomnes added a commit that referenced this pull request Jun 15, 2026
bcomnes added a commit that referenced this pull request Jun 15, 2026
bcomnes added a commit that referenced this pull request Jun 16, 2026
bcomnes added a commit that referenced this pull request Jun 16, 2026
bcomnes added a commit that referenced this pull request Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants