Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces xUnit collection fixtures to share a single ASP.NET Core test host across related test classes, reducing per-test setup and removing reliance on the older GrantManagerWebTestBase inheritance pattern.
Changes:
- Added
WebTestFixture+WebTestCollectionforUnity.GrantManager.Web.Testsand updated tests to consume the shared fixture. - Added
ComponentTestFixture+ComponentTestCollectionforUnity.Flex.Web.Testsand updated component tests to consume the shared fixture. - Updated several tests to use
WebApplicationFactoryclients / DI (fixture.Services) instead of base-class helpers.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/WebTestFixture.cs | Adds shared WebApplicationFactory-based fixture + collection for web tests. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/Pages/Index_Tests.cs | Moves to collection fixture and uses HttpClient from shared factory. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/Components/SummaryWidgetTests.cs | Uses shared fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/Components/ProjectInfoWidgetTests.cs | Uses shared fixture DI (incl. IAuthorizationService) instead of per-test logger hacks. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/Components/FundingAgreementInfoWidgetTests.cs | Uses shared fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/Components/AttachmentControllerTests.cs | Removes inheritance from web test base; remains a direct unit test. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/Components/AssessmentScoresWidgetTests.cs | Removes inheritance from web test base; remains a direct unit test. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/Components/ApplicationTagWidgetTests.cs | Removes inheritance from web test base; remains a direct unit test. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/Components/ApplicationContactWidgetTests.cs | Removes inheritance from web test base; removes env-var logging workaround. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/Components/ApplicantInfoWidgetTests.cs | Uses shared fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/ComponentTestFixture.cs | Adds shared fixture + collection for Flex component tests. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/YesNoWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/TextDefinitionWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/TextAreaWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/TextAreaDefinitionWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/SelectListWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/SelectListDefinitionWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/RadioWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/DataGridWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/DataGridDefinitionWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/CurrencyWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/CurrencyDefinitionWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/CheckboxWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/CheckboxGroupWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
| applications/Unity.GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/CheckboxGroupDefinitionWidgetTests.cs | Uses component collection fixture DI to set LazyServiceProvider. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/WebTestFixture.cs
Outdated
Show resolved
Hide resolved
...GrantManager/modules/Unity.Flex/test/Unity.Flex.Web.Tests/Components/ComponentTestFixture.cs
Outdated
Show resolved
Hide resolved
applications/Unity.GrantManager/test/Unity.GrantManager.Web.Tests/Pages/Index_Tests.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.