Feature/ab#30429 profile contacts add agent#2052
Merged
Conversation
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds applicant agent contact support to the applicant profile “ContactInfo” data aggregation so the portal can display agent details alongside profile- and application-level contacts, including application reference numbers.
Changes:
- Extend
ContactInfoDataProvider/ApplicantProfileContactServiceto retrieve and merge Applicant Agent contacts matched by normalized OIDC subject. - Add
ReferenceNotoContactInfoItemDtoand populate it for application and agent-derived contacts. - Update/extend unit tests and update the applicant-portal provider documentation to reflect the new data source and join paths.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| documentation/applicant-portal/applicant-profile-data-providers.md | Updates provider documentation/diagrams to include applicant agent contacts and ReferenceNo joins. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/ApplicantProfile/ContactInfoDataProvider.cs | Merges profile contacts + application contacts + applicant agent contacts. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application/ApplicantProfile/ApplicantProfileContactService.cs | Adds applicant-agent contact query and joins Application to populate ReferenceNo. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application.Contracts/ApplicantProfile/ProfileData/ContactInfoItemDto.cs | Adds ReferenceNo field to contact DTO. |
| applications/Unity.GrantManager/src/Unity.GrantManager.Application.Contracts/ApplicantProfile/IApplicantProfileContactService.cs | Adds new service method for applicant agent contacts. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Application.Tests/Contacts/ContactInfoServiceTests.cs | Adds tests for applicant agent contact retrieval and ReferenceNo mapping. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Application.Tests/Contacts/ContactInfoDataProviderTests.cs | Updates provider tests to assert agent retrieval + merged counts/order. |
| applications/Unity.GrantManager/test/Unity.GrantManager.Application.Tests/Applicants/ApplicantProfileDataProviderTests.cs | Updates test setup to stub new contact service method. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
....GrantManager/src/Unity.GrantManager.Application/ApplicantProfile/ContactInfoDataProvider.cs
Outdated
Show resolved
Hide resolved
...anager/src/Unity.GrantManager.Application/ApplicantProfile/ApplicantProfileContactService.cs
Show resolved
Hide resolved
...anager/src/Unity.GrantManager.Application/ApplicantProfile/ApplicantProfileContactService.cs
Show resolved
Hide resolved
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.