Change rules based toolchain macOS conditions to Apple#614
Open
keith wants to merge 1 commit intobazelbuild:mainfrom
Open
Change rules based toolchain macOS conditions to Apple#614keith wants to merge 1 commit intobazelbuild:mainfrom
keith wants to merge 1 commit intobazelbuild:mainfrom
Conversation
keith
requested review from
armandomontanez,
c-mita,
hvadehra,
pzembrod and
trybka
as code owners
Contributor
|
That's great ! |
keith
force-pushed
the
ks/change-rules-based-toolchain-macos-conditions-to-apple
branch
2 times, most recently
from
bf20a1f to
2bfe8a4
Compare
keith
force-pushed
the
ks/change-rules-based-toolchain-macos-conditions-to-apple
branch
from
2bfe8a4 to
638ca4b
Compare
This allows you to write a rules based toolchain that targets Apple platforms that aren't macOS. Fixes bazelbuild#370
keith
force-pushed
the
ks/change-rules-based-toolchain-macos-conditions-to-apple
branch
from
638ca4b to
4e764a8
Compare
armandomontanez
approved these changes
Mar 26, 2026
armandomontanez
added
P2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows you to write a rules based toolchain that targets Apple
platforms that aren't macOS.
I made this overridable since there are other constraints in apple_support
that denote you're building for an apple platform. But those only matter
if you're building a non-standard platform.
Fixes #370