fix: namespace package calculation on windows#3693
Merged
rickeylev merged 10 commits intobazel-contrib:mainfrom Apr 12, 2026
Merged
fix: namespace package calculation on windows#3693rickeylev merged 10 commits intobazel-contrib:mainfrom
rickeylev merged 10 commits intobazel-contrib:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors path handling in repo_utils.bzl by introducing centralized normalization and relative path calculation functions, which are then utilized in pypi_repo_utils.bzl. However, the implementation of _is_relative_to contains reversed logic that incorrectly identifies paths as being outside the repository root. Additionally, _relative_to fails to preserve original casing on Windows and introduces unexpected trailing slashes, which may break downstream tools and imports.
22f48cd to
bcc6cab
Compare
aignas
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when the repo computes the namespace package files on
Windows, it incorrectly computes the filename because of
C:handlingand case-sensitivity, resulting in a repo-phase error.
To fix, modify the relative path computation functions to detect if the
platform is Windows and make comparisions case-insensitive.